Merged
Conversation
ZainabImadulla
requested changes
Nov 24, 2025
Contributor
ZainabImadulla
left a comment
ZainabImadulla
left a comment
There was a problem hiding this comment.
This looks amazing so far 🚀 just a few small changes
| @@ -9,15 +9,15 @@ interface DisasterLabelProps { | |||
| editableTags: boolean; | |||
| } | |||
|
|
|||
Contributor
There was a problem hiding this comment.
If these need to be used in other files, consider moving these to the types folder
Contributor
Author
There was a problem hiding this comment.
These are only used in that file.
Contributor
There was a problem hiding this comment.
These are getting used in the side-view component as well
frontend/app/expense-tracker/expense-table/category-options.tsx
Outdated
Show resolved
Hide resolved
ZainabImadulla
requested changes
Nov 24, 2025
| @@ -9,15 +9,15 @@ interface DisasterLabelProps { | |||
| editableTags: boolean; | |||
| } | |||
|
|
|||
Contributor
There was a problem hiding this comment.
These are getting used in the side-view component as well
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#152
entirely new tan-stack table
Checklist